Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74700222
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -311,7 +311,7 @@ class HasSeed(Params):
def __init__(self):
super(HasSeed, self).__init__()
- self._setDefault(seed=hash(type(self).__name__))
+ self._setDefault(seed=None)
--- End diff --
Hm you may be right (looks like it converts to an Int actually? same
point). I looked over the Python code, and virtually every class that extends
HasSeed also appears to set seed=None by default. So in a way this change
doesn't do much at all.
I'm going to correct the test I missed, and change one class that fixes an
odd seed in its API, and propose that. It would at least change behavior on the
Scala side, and make the Python side internally consistent and consistent with
Scala.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
