Github user markhamstra commented on the issue:

    https://github.com/apache/spark/pull/14557
  
    There are multiple issues with this PR.  Some are at a more stylistic 
level, but some include deeper issues -- e.g. see SPARK-17064.  Most 
fundamentally, this PR is the wrong solution at least in the sense that it does 
not implement a minimal fix without other side effects.  The problem is that 
TaskCommitDenied is not being handled properly when a duplicate Task tries to 
commit a result that has already been successfully committed by another attempt 
of this Task.  The proper fix needs to be at that point of committing duplicate 
results, not by making the larger, unnecessary change in how we handle 
cancellation/interruption of other Tasks in a TaskSet when one of them produces 
a FetchFailed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to