Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13950
> Wondering if the test for location header is really needed
Always a good idea to have tests, even if you feel the code is simple. Then
if someone needs to change the code later, the tests might catch anything wrong.
Also, it seems you implemented the proxyBase approach I suggested. Can you
confirm that, when proxying is enabled, you can still look at the app's UI by
going to the app's web server directly, and not just through the master UI?
(In YARN you get redirected to the "master" - the YARN RM in that case -
when going to the app's web server, but here you don't have any code to do
that, so the UI should still work when setting proxyBase.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
