Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14619#discussion_r74895818
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -1636,6 +1638,30 @@ object ReplaceExceptWithAntiJoin extends 
Rule[LogicalPlan] {
     }
     
     /**
    + * Insert a [[Scanner]] operator over [[MultiInstanceRelation]], then 
combine [[Project]]s and
    + * [[Filter]]s with this operator, then the planner can match on the 
[[Scanner]] node directly.
    + */
    +object InsertRelationScanner extends Rule[LogicalPlan] with 
PredicateHelper {
    --- End diff --
    
    This doesn't reuse the existing `ColumnPruning` and `PushDownPredicate` 
rules. I'd like to add the wrapper at the very beginning, e.g. 
`SessionCatalog.lookUpRelation`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to