Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14551
@nicklavers I agree it's not great to assume that the current output is
correct, though I strongly suspect it is. We'd ideally do some analysis to
understand what the expected range of outcomes are given the stochastic process
behind this and write a more robust test. For the moment I'm comfortable just
going with the current output, because a difference is expected here, and more
general parts of the test pass, your fix is obviously addressing a bug, and so
I can't see that it's any worse, at least. I'd welcome more robust analysis but
am OK with getting this in as-is, in practice.
It looks like the SparkR test needs a similar treatment, and then I suspect
it's all good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
