Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/14359#discussion_r75361458
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -161,31 +161,43 @@ private[spark] object RandomForest extends Logging {
None
}
- // FIFO queue of nodes to train: (treeIndex, node)
- val nodeQueue = new mutable.Queue[(Int, LearningNode)]()
+ /*
+ FILO queue of nodes to train: (treeIndex, node)
+ We make this FILO by always inserting nodes by appending (+=) and
removing with dropRight.
--- End diff --
the methods described here still refer to the original queue data structure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
