Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12889#discussion_r75385604
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -788,6 +788,8 @@ class GeneralizedLinearRegressionModel private[ml] (
@Since("2.0.0")
override def write: MLWriter =
new
GeneralizedLinearRegressionModel.GeneralizedLinearRegressionModelWriter(this)
+
+ override val numFeatures: Int = coefficients.size
--- End diff --
numFeatures has always been here its just been the default implementation -
but I guess the since wouldn't be too confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
