Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/14673#discussion_r75389586
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -93,6 +93,8 @@ class JobProgressListener(conf: SparkConf) extends
SparkListener with Logging {
val retainedStages = conf.getInt("spark.ui.retainedStages",
SparkUI.DEFAULT_RETAINED_STAGES)
val retainedJobs = conf.getInt("spark.ui.retainedJobs",
SparkUI.DEFAULT_RETAINED_JOBS)
+ val retainedTasks = conf.getInt("spark.ui.retainedTasks",
SparkUI.DEFAULT_RETAINED_TASKS)
--- End diff --
ah good point that hashMap can only hold int number of entries.
My point was that with taskId being a long and assuming taskId = 0 through
X, X here could be a long (2^64) and thus you could have 2^64 number of tasks.
If you can have 2^64 number of tasks then this config should allow you to
configure it to retain all of those tasks.
I'm fine with leaving an int.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
