Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14680
@jaceklaskowski It seems the test [here]
(https://github.com/apache/spark/blob/e50efd53f073890d789a8448f850cc219cca7708/sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala#L715-L724)
is related with this change. It seems it will passes the test if we change
`TextFileFormat` to `TEXT`.
BTW, how about changing them to `Parquet` and `Text` maybe? I believe this
might be about personal taste though.. I feel like `shortName.toUpperCase` is
not always the string representation of each data source.
I mean.. if my understanding is correct, the proper name might be `Parquet`
rather than `PARQUET`, at least. It seems `ORC`, `JSON` and `CSV` are correct
names because they are abbreviated names but I feel like it is questionable for
`PARQUET` and `TEXT`.
If the purpose of this change is only to see the information about plans to
human via `explain(...)` regardless of anything, it might be better if it is
more close to human readable and correct names as string representation.
This is just my personal opinion. I think we need @rxin 's sign off here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
