Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13152#discussion_r75426383
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala ---
@@ -50,12 +50,20 @@ class BlockManagerMaster(
logInfo("Removal of executor " + execId + " requested")
}
- /** Register the BlockManager's id with the driver. */
+ /**
+ * Register the BlockManager's id with the driver. The input
BlockManagerId does not contain
+ * topology information. This information is obtained from the master
and we respond with an
+ * updated BlockManagerId fleshed out with this information.
+ */
def registerBlockManager(
- blockManagerId: BlockManagerId, maxMemSize: Long, slaveEndpoint:
RpcEndpointRef): Unit = {
+ blockManagerId: BlockManagerId,
--- End diff --
indent 4 spaces
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
