Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14705#discussion_r75430000 --- Diff: R/pkg/R/functions.R --- @@ -3115,6 +3166,11 @@ setMethod("dense_rank", #' #' This is equivalent to the LAG function in SQL. #' +#' @param x the column as a character string or a Column to compute on. +#' @param offset the number of rows back from the current row from which to obtain a value. +#' If not specified, the default is 1. +#' @param defaultValue default to use when the offset row does not exist. +#' @param ... further arguments to be passed to or from other methods. --- End diff -- This is actually the issue I raised at the end of #14558. In the same doc, it also includes generic definition, which also comes with `...` and this has the actual meaning "further arguments to be passed".
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org