Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1723#discussion_r16407308
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala ---
    @@ -106,6 +106,27 @@ abstract class DStream[T: ClassTag] (
       /** Return the StreamingContext associated with this DStream */
       def context = ssc
     
    +  /* Find the creation callSite */
    +  val creationSite = Utils.getCallSite
    +
    +  /* Store the RDD creation callSite in threadlocal */
    +  private def setRDDCreationCallSite() = {
    +    ssc.sparkContext.setLocalProperty(Utils.CALL_SITE_SHORT, 
creationSite.shortForm)
    --- End diff --
    
    These two methods are pretty much similar. Can you please merge them? Make 
the `callsite` parameter have the default value of `creationSite`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to