Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r75545710
--- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoConf.scala ---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.crypto
+
+import javax.crypto.KeyGenerator
+
+import org.apache.hadoop.io.Text
+import org.apache.hadoop.security.Credentials
+
+import org.apache.spark.SparkConf
+
+/**
+ * CryptoConf is a class for Crypto configuration
+ */
+private[spark] object CryptoConf {
+ /**
+ * Constants and variables for spark shuffle file encryption
+ */
+ val SPARK_SHUFFLE_TOKEN = new Text("SPARK_SHUFFLE_TOKEN")
+ val SPARK_SHUFFLE_ENCRYPTION_ENABLED = "spark.shuffle.encryption.enabled"
+ val SPARK_SHUFFLE_ENCRYPTION_KEYGEN_ALGORITHM =
"spark.shuffle.encryption.keygen.algorithm"
+ val DEFAULT_SPARK_SHUFFLE_ENCRYPTION_KEYGEN_ALGORITHM = "HmacSHA1"
+ val SPARK_SHUFFLE_ENCRYPTION_KEY_SIZE_BITS =
"spark.shuffle.encryption.keySizeBits"
+ val DEFAULT_SPARK_SHUFFLE_ENCRYPTION_KEY_SIZE_BITS = 128
+
+ /**
+ * Check whether shuffle file encryption is enabled. It is disabled by
default.
+ */
+ def isShuffleEncryptionEnabled(sparkConf: SparkConf): Boolean = {
+ if (sparkConf != null) {
+ sparkConf.getBoolean(SPARK_SHUFFLE_ENCRYPTION_ENABLED, false)
+ } else {
+ false
+ }
+ }
+
+ /**
+ * Setup the cryptographic key used by file shuffle encryption in
credentials. The key is
+ * generated using [[KeyGenerator]]. The algorithm and key length is
specified by the
+ * [[SparkConf]].
+ */
+ def initSparkShuffleCredentials(conf: SparkConf, credentials:
Credentials): Unit = {
+ if (credentials.getSecretKey(SPARK_SHUFFLE_TOKEN) == null) {
+ val keyLen = conf.getInt(SPARK_SHUFFLE_ENCRYPTION_KEY_SIZE_BITS,
+ DEFAULT_SPARK_SHUFFLE_ENCRYPTION_KEY_SIZE_BITS)
+ require(keyLen == 128 || keyLen == 192 || keyLen == 256)
--- End diff --
As an example of the new config stuff, this can all be encapsulated in the
config itself.
```
val SPARK_SHUFFLE_ENCRYPTION_KEY_SIZE_BITS = ConfigBuilder("...")
.intConf
.checkValues(Set(128, 192, 256))
.createWithDefault(128)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
