Github user mengxr commented on the issue: https://github.com/apache/spark/pull/14705 Agree with @felixcheung . Let do the `setGeneric(, ...)` and do not use `...` in function definition if it is not required. Note that having every param documented is not a strict requirement of CRAN submission. It would be great if we can merge this PR fist and fix minor issues after since it touches many files in SparkR.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org