Github user hqzizania commented on a diff in the pull request: https://github.com/apache/spark/pull/14717#discussion_r75566293 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1331,8 +1343,8 @@ private class LogisticCostFun( standardization: Boolean, bcFeaturesStd: Broadcast[Array[Double]], regParamL2: Double, - multinomial: Boolean) extends DiffFunction[BDV[Double]] { - + multinomial: Boolean, + depth: Int) extends DiffFunction[BDV[Double]] { --- End diff -- OK, I will change it to aggregationDepth and create two follow up JIRAs, one for SharedParamsCodeGen.scala and the other about the expert formula.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org