Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14731#discussion_r75583446
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
---
@@ -241,16 +233,21 @@ class FileInputDStream[K, V, F <: NewInputFormat[K,
V]](
* The files with mod time T+5 are not remembered and cannot be
ignored (since, t+5 > t+1).
* Hence they can get selected as new files again. To prevent this,
files whose mod time is more
* than current batch time are not considered.
+ * @param fs file status
+ * @param currentTime time of the batch
+ * @param modTimeIgnoreThreshold the ignore threshold
+ * @return true if the file has been modified within the batch window
*/
- private def isNewFile(path: Path, currentTime: Long,
modTimeIgnoreThreshold: Long): Boolean = {
+ private def isNewFile(fs: FileStatus, currentTime: Long,
modTimeIgnoreThreshold: Long): Boolean = {
--- End diff --
also fs is pretty confusing, because in this context it is often used to
refer to as FileSystem. We should pick a different word.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
