Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14723#discussion_r75613743 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala --- @@ -90,6 +98,21 @@ class SortBasedAggregationIterator( // compared to MutableRow (aggregation buffer) directly. private[this] val safeProj: Projection = FromUnsafeProjection(valueAttributes.map(_.dataType)) + // AggregationFunction which store generic object in AggregationBuffer. + // @see [[WithObjectAggregationBuffer]] for more information + private val aggFunctionsWithObjectAggregationBuffer = aggregateFunctions.collect { + case (ag: ImperativeAggregate with WithObjectAggregateBuffer) => ag --- End diff -- how about we make `WithObjectAggregateBuffer` extends `ImperativeAggregate`?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org