Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r75700225
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -204,6 +213,7 @@ case object TaskResultLost extends TaskFailedReason {
@DeveloperApi
case object TaskKilled extends TaskFailedReason {
override def toErrorString: String = "TaskKilled (killed intentionally)"
+ override val countTowardsTaskFailures: Boolean = false
--- End diff --
the switch to a `val` came from an earlier discussion with @kayousterhout
... there was some other confusion, thought maybe changing to a val would make
it more clear it is a constant. But I don't think either of feels strongly,
the argument to switch to a val was pretty weak. I can change it back
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
