Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14749#discussion_r75783595
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala
 ---
    @@ -54,6 +54,10 @@ abstract class Collect extends ImperativeAggregate {
     
       override def inputAggBufferAttributes: Seq[AttributeReference] = Nil
     
    +  // Both `CollectList` and `CollectSet` are non-deterministic since their 
results depend on the
    +  // actual order of input rows.
    +  override def deterministic: Boolean = false
    --- End diff --
    
    Yea. Also, there's no set type in Spark SQL, thus the result set is 
actually just a list without duplicated elements.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to