Github user WeichenXu123 commented on the issue:

    https://github.com/apache/spark/pull/13796
  
    I found a problem in the merged code:  when reg == 0 the minimizer of 
softmax cost is not unique.
    In such case, it will cause Hessian matrix non-invertible, and I thinks it 
may cause quasi-newton's methods such as LBFGS run into numerical problems.
    so, is it better to forbid the `reg==0` case for softmax parameters ? 
    cc @sethah @dbtsai 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to