Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10896#discussion_r75894983 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala --- @@ -19,34 +19,94 @@ package org.apache.spark.sql.execution.aggregate import org.apache.spark.sql.catalyst.expressions._ import org.apache.spark.sql.catalyst.expressions.aggregate._ +import org.apache.spark.sql.catalyst.plans.physical.Distribution import org.apache.spark.sql.execution.SparkPlan import org.apache.spark.sql.execution.streaming.{StateStoreRestoreExec, StateStoreSaveExec} /** + * A pattern that finds aggregate operators to support partial aggregations. + */ +object PartialAggregate { + + def unapply(plan: SparkPlan): Option[Distribution] = plan match { + case agg: AggregateExec + if agg.aggregateExpressions.map(_.aggregateFunction).forall(_.supportsPartial) => --- End diff -- Put this in a function. This can be found a few times in the code.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org