Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r75913315
--- Diff:
core/src/main/scala/org/apache/spark/serializer/SerializerManager.scala ---
@@ -143,7 +179,25 @@ private[spark] class
SerializerManager(defaultSerializer: Serializer, conf: Spar
val stream = new BufferedInputStream(inputStream)
getSerializer(implicitly[ClassTag[T]])
.newInstance()
- .deserializeStream(wrapForCompression(blockId, stream))
+ .deserializeStream(wrapStream(blockId, stream))
.asIterator.asInstanceOf[Iterator[T]]
}
}
+
+private[spark] object SerializerManager {
+ /**
+ * Setup the cryptographic key used by IO encryption in credentials. The
key is generated using
+ * [[KeyGenerator]]. The algorithm and key length is specified by the
[[SparkConf]].
+ */
+ def initShuffleEncryptionKey(conf: SparkConf, credentials: Credentials):
Unit = {
--- End diff --
I still think this makes more sense in `SecurityManager`; also, this is
more than shuffle, so maybe just `initEncryptionKey` or ``initIOEncryptionKey`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
