Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75997361
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala
---
@@ -131,6 +150,11 @@ class SortBasedAggregationIterator(
firstRowInNextGroup = currentRow.copy()
}
}
+
+ // Serializes the generic object stored in aggregation buffer for
TypedImperativeAggregate
+ // aggregation functions.
+ serializeTypedAggregateBuffer(sortBasedAggregationBuffer)
--- End diff --
(basically, when we call `eval`, we always get the original object)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
