Github user petermaxlee commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14728#discussion_r76108686
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
 ---
    @@ -41,36 +40,59 @@ class FileStreamSource(
         metadataPath: String,
         options: Map[String, String]) extends Source with Logging {
     
    +  import FileStreamSource._
    +
    +  private val sourceOptions = new FileStreamOptions(options)
    +
       private val fs = new 
Path(path).getFileSystem(sparkSession.sessionState.newHadoopConf())
       private val qualifiedBasePath = fs.makeQualified(new Path(path)) // can 
contains glob patterns
    -  private val metadataLog = new HDFSMetadataLog[Seq[String]](sparkSession, 
metadataPath)
    +
    +  private val metadataLog = new 
HDFSMetadataLog[Seq[FileEntry]](sparkSession, metadataPath)
    +
    --- End diff --
    
    metadataLog is not logically related to qualifiedBasePath


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to