Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14746#discussion_r76177017
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala 
---
    @@ -204,10 +206,67 @@ class SQLViewSuite extends QueryTest with 
SQLTestUtils with TestHiveSingleton {
         }
       }
     
    -  test("should allow CREATE permanent VIEW when a TEMPORARY VIEW with same 
name exists") {
    +  test("ALTER VIEW: alter a temporary view when a permanent VIEW with same 
name exists") {
    +    verifyAlterViewWithIdenticalName(isTempAlteredView = true)
    +  }
    +
    +  test("ALTER VIEW: alter a persistent view when a temp VIEW with same 
name exists") {
    +    verifyAlterViewWithIdenticalName(isTempAlteredView = false)
    +  }
    +
    +  private def verifyAlterViewWithIdenticalName (isTempAlteredView: 
Boolean) = {
    --- End diff --
    
    how about `alterTempView`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to