Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14800
True, but, in the with-replacement case, you're no longer selecting a
subset to begin with, because an element can appear twice. "Sample" does
generally mean "take a smaller set" but it also means things like "sampling
from a distribution".
I wouldn't feel strongly about it except that we're taking away behavior
that worked fine.
The RDD API for example, doesn't enforce that the rate must be <= 1 (even
for without replacement, which is wrong).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
