Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14804
Ugh, yeah that's wrong in the sense that we are not showing MB, but MiB.
I'd favor fixing the labels here and in Utils.bytesToString?
Then again, I see that we will also parse input of "500kb" as if it's
"500KiB", using 1024 not 1000. That's wrong too really. But fixing it means a
bit of a behavior change. We can support "500KB" or "500kb" but it would now
mean 500*1000 bytes not 500*1024.
Well, maybe best to be consistently wrong than inconsistently wrong. Anyone
feel at all inclined to take the hit in behavior change or just leave it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
