Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13852#discussion_r76291119
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala
---
@@ -45,7 +45,7 @@ abstract class Collect extends ImperativeAggregate {
override def inputTypes: Seq[AbstractDataType] = Seq(AnyDataType)
- override def supportsPartial: Boolean = false
+ override def forceSortAggregate: Boolean = true
--- End diff --
oh, after changing this name, it will not show that we do not partial agg
for this function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
