Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14815#discussion_r76334971
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1386,15 +1386,17 @@ object EliminateOuterJoin extends Rule[LogicalPlan]
with PredicateHelper {
object PushPredicateThroughJoin extends Rule[LogicalPlan] with
PredicateHelper {
/**
* Splits join condition expressions into three categories based on the
attributes required
--- End diff --
It sounds like this PR is targeting both join conditions and filter
predicates. Could you update the code comment of this line and the title of the
PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
