Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14817#discussion_r76375770 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -142,6 +140,27 @@ private[hive] case class MetastoreRelation( } ) + private def getSize(f: Path): Long = { --- End diff -- I see what you're doing but this method no longer really does what it says. I think this is going to be error-prone.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org