Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/14815
  
    Looks pretty good to me! 
    
    Could you also add one more test case for testing the following scenario: 
    ```
    only consider pushing down those expressions that precede the first 
non-deterministic expression in the condition.
    ```
    
    I am just afraid the others might break it in the future. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to