Github user holdenk commented on the issue:

    https://github.com/apache/spark/pull/14830
  
    Thank for taking the time to do this @Stibbons I think its great progress. 
Doing a quick skim it seems like there are a number of places where the import 
reordering may have inadvertanly changed what the users will see in the 
examples we have in the documentation - which is probably not what was intended.
    
    I've left line comments in some of the places where I noticed them but 
there are probably quite a few others since it was just a quick first skim.
    
    I'd suggest doing a quick audit yourself and then consider building the 
documentation to verify that it hasn't changed in any unintended ways by your 
change.
    
    Once again thanks for taking on this task! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to