Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14858#discussion_r76570285
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -63,7 +63,7 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
override val uid: String
/** @group setParam */
@Since("1.4.0")
- def setSplits(value: Array[Double]): this.type = set(splits, value)
+ def setSplits(value: Array[Double]): this.type = set(splits,
value.filter(!_.isNaN))
--- End diff --
How about just rejecting splits with NaN? I don't see a valid reason a
caller could specify splits bounded by NaN since it has no ordering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
