Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14731#discussion_r76594233
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -244,6 +244,31 @@ class SparkHadoopUtil extends Logging {
}
/**
+ * List directories/files matching the path and return the `FileStatus`
results.
+ * If the pattern is not a regexp then a simple `getFileStatus(pattern)`
+ * is called to get the status of that path.
+ * If the path/pattern does not match anything in the filesystem,
+ * an empty sequence is returned.
+ * @param pattern pattern
+ * @return a possibly empty array of FileStatus entries
+ */
+ def globToFileStatus(pattern: Path): Array[FileStatus] = {
--- End diff --
Yea, but then that's wrong if for example my path actually has a ? or ^ or
] in it. It doesn't seem essential and seems even problematic to add this
behavior change to an otherwise clear fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
