Github user frreiss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14803#discussion_r76646983
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
 ---
    @@ -129,13 +129,20 @@ class FileStreamSource(
         val files = metadataLog.get(Some(startId + 1), 
Some(endId)).flatMap(_._2)
         logInfo(s"Processing ${files.length} files from ${startId + 1}:$endId")
         logTrace(s"Files are:\n\t" + files.mkString("\n\t"))
    +    val newOptions = if (!SparkHadoopUtil.get.isGlobPath(new Path(path))) {
    --- End diff --
    
    I recommend putting this code into the initialization code at the top of 
this file that sets `qualifiedBasePath` (currently lines 47-50). That way all 
the code that interprets the meaning of the `path` parameter` will be in one 
place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to