Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14866#discussion_r76665332 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1534,6 +1542,34 @@ object SimplifyCaseConversionExpressions extends Rule[LogicalPlan] { } /** + * Check if ther eany cartesian products between joins of any type in the optimized plan tree. + * Throw an error if a cartesian product is found without an explicit cross join specified. + * This rule is effectively disabled if the CROSS_JOINS_ENABLED flag is true. + */ +case class CheckCartesianProducts(conf: CatalystConf) extends Rule[LogicalPlan] { + def apply(plan: LogicalPlan): LogicalPlan = + if (conf.allowCartesianProduct) { + plan + } else plan transform { + case j @ Join(left, right, joinType, conditions) --- End diff -- `j @ Join(left, right, Inner(false) | LeftOuter | RightOuter | FullOuter, condition) =>`?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org