Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14835#discussion_r76668460
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala ---
    @@ -100,6 +100,7 @@ class HistoryServerSuite extends SparkFunSuite with 
BeforeAndAfter with Matchers
         "minDate app list json" -> "applications?minDate=2015-02-10",
         "maxDate app list json" -> "applications?maxDate=2015-02-10",
         "maxDate2 app list json" -> 
"applications?maxDate=2015-02-03T16:42:40.000GMT",
    +    "limit app list json" -> "applications?limit=3",
    --- End diff --
    
    limit=-1 will actually return the whole list, I just pass the int to `take` 
and that's how that function works, I though this was a good default value 
(which is why it's the default value in the js file)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to