Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r76834689 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -63,6 +65,21 @@ trait Generator extends Expression { } /** + * A collection producing [[Generator]]. This trait provides a different path for code generation, + * by allowing code generation to return either an [[ArrayData]] or a [[MapData]] object. + */ +trait CollectionGenerator extends Generator { + /** The position of an element within the collection should also be returned. */ + def position: Boolean + + /** Rows will be inlined during generation. */ + def inline: Boolean + + /** The schema of the returned collection object. */ + def collectionSchema: DataType = dataType +} --- End diff -- I needed a way to make sure that the collection based code path (iteration over ArrayData/MapData) can be easily identified. The other option would be to hard-code all Generators that support this code path, but that seems just wrong to me.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org