Github user chutium commented on the pull request:

    https://github.com/apache/spark/pull/2044#issuecomment-52748630
  
    actually i totally agree with you @liancheng , this was reported in user 
list 
http://apache-spark-user-list.1001560.n3.nabble.com/sqlContext-parquetFile-path-fails-if-path-is-a-file-but-succeeds-if-a-directory-td12345.html
    
    i think he is also right, parameter of sqlContext.parquetFile should be a 
dir of parquet files (at better with a _metadata file in it), but this should 
not be a mandatory requirement, our javadoc
    
https://spark.apache.org/docs/latest/api/java/org/apache/spark/sql/SQLContext.html#parquetFile(java.lang.String)
    says also, this method "Loads a Parquet file", not "loads a dir of parqauet 
files"...
    
    otherwise maybe we should rename this method to sqlContext.parquetDir or 
somthing
    
    and this PR is not "try to handle", it is more like "try to ignore useless 
check" :) it is already handled by children.find(...)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to