Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14712#discussion_r76924362
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(conf: 
SparkConf, hadoopConf: Configurat
         }
       }
     
    +  override def alterTableStats(tableDefinition: CatalogTable): Unit = 
withClient {
    --- End diff --
    
    I'm not sure we wanna support the second way to set properties. If users 
set them with ALTER TABLE, we should throw exception. cc @yhuai @gatorsmile 
what do you think?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to