Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77071952
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -28,14 +28,24 @@ abstract sealed class SortDirection {
def sql: String
}
+// default null order is firt for asc
case object Ascending extends SortDirection {
override def sql: String = "ASC"
}
+case object AscendingNullLast extends SortDirection {
--- End diff --
Is the following better ?
```scala
case class SortOrder(child: Expression, direction: SortDirection,
nullOrdering: NullOrdering = direction.DefaultNullOrdering) {
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
