Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14881#discussion_r77082768
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -1308,3 +1315,104 @@ setMethod("write.ml", signature(object = 
"ALSModel", path = "character"),
               function(object, path, overwrite = FALSE) {
                 write_internal(object, path, overwrite)
               })
    +
    +#' (One-Sample) Kolmogorov-Smirnov Test
    +#'
    +#' @description
    +#' \code{spark.kstest} Conduct the two-sided Kolmogorov-Smirnov (KS) test 
for data sampled from a
    +#' continuous distribution.
    +#'
    +#' By comparing the largest difference between the empirical cumulative
    +#' distribution of the sample data and the theoretical distribution we can 
provide a test for the
    +#' the null hypothesis that the sample data comes from that theoretical 
distribution.
    +#'
    +#' Users can call \code{summary} to obtain a summary of the test, and 
\code{print.summary.KSTest}
    +#' to print out a summary result.
    +#'
    +#' @details
    +#' For more details, see
    +#' 
\href{http://spark.apache.org/docs/latest/mllib-statistics.html#hypothesis-testing}{
    +#' MLlib: Hypothesis Testing}.
    --- End diff --
    
    maybe put this in @seealso? That seems to be the typical way to add link in 
our doc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to