Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14433#discussion_r77125115
  
    --- Diff: core/src/main/scala/org/apache/spark/internal/Logging.scala ---
    @@ -135,7 +136,12 @@ private[spark] trait Logging {
             val replLevel = Option(replLogger.getLevel()).getOrElse(Level.WARN)
             if (replLevel != rootLogger.getEffectiveLevel()) {
               System.err.printf("Setting default log level to \"%s\".\n", 
replLevel)
    -          System.err.println("To adjust logging level use 
sc.setLogLevel(newLevel).")
    +          if (SparkSubmit.isRShell) {
    --- End diff --
    
    I personally think it's a bit ugly to pipe through this info with extra 
methods and so on. It seems simpler just to amend the message to also state the 
right command for sparkr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to