Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14901#discussion_r77127538
  
    --- Diff: 
examples/src/main/scala/org/apache/spark/examples/sql/SparkSQLExample.scala ---
    @@ -203,7 +203,7 @@ object SparkSQLExample {
         // No pre-defined encoders for Dataset[Map[K,V]], define explicitly
         implicit val mapEncoder = 
org.apache.spark.sql.Encoders.kryo[Map[String, Any]]
         // Primitive types and case classes can be also defined as
    -    implicit val stringIntMapEncoder: Encoder[Map[String, Int]] = 
ExpressionEncoder()
    +    // implicit val stringIntMapEncoder: Encoder[Map[String, Any]] = 
ExpressionEncoder()
    --- End diff --
    
    This compiled before though, right? you're saying it's unnecessary because 
of the implicit in the line above? that seems fine but let's delete these 2 
lines then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to