Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14914#discussion_r77129894
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -999,7 +999,7 @@ object Matrices {
val data = new ArrayBuffer[(Int, Int, Double)]()
dnMat.foreachActive { (i, j, v) =>
if (v != 0.0) {
- data.append((i, j + startCol, v))
+ data.+=((i, j + startCol, v))
--- End diff --
You can write `data += ((i, j + startCol, v))`
Yes, I think it may be worth optimizing this because append actually
expects varargs.
There are many more instances in the code though. I think it's reasonable
to fix this everywhere. At least non-test code, and at least anything where
performance could be important.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
