Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14858#discussion_r77132904
--- Diff: docs/ml-features.md ---
@@ -1102,7 +1102,8 @@ for more details on the API.
## QuantileDiscretizer
`QuantileDiscretizer` takes a column with continuous features and outputs
a column with binned
-categorical features. The number of bins is set by the `numBuckets`
parameter.
+categorical features. The number of bins is set by the `numBuckets`
parameter, but it is
--- End diff --
OK, but this doesn't specify the behavior. It should be explicit that while
data will go into buckets 0 through numBuckets-1, that NaN values will be
counted in bucket numBuckets.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
