Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77200411
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1204,9 +1204,29 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef]
with Logging {
*/
override def visitSortItem(ctx: SortItemContext): SortOrder =
withOrigin(ctx) {
if (ctx.DESC != null) {
- SortOrder(expression(ctx.expression), Descending)
+ if (ctx.nullOrder != null) {
+ ctx.nullOrder.getType match {
+ case SqlBaseParser.FIRST =>
+ SortOrder(expression(ctx.expression), Descending, NullFirst)
+ case SqlBaseParser.LAST =>
+ SortOrder(expression(ctx.expression), Descending)
+ case _ => throw new ParseException(s"NULL ordering can be only
FIRST or LAST", ctx)
--- End diff --
yep. I will remove this default case. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
