Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r77278880
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -765,14 +807,16 @@ private[spark] class TaskSetManager(
case e: TaskFailedReason => // TaskResultLost, TaskKilled, and
others
logWarning(failureReason)
None
+ }
- case e: TaskEndReason =>
- logError("Unknown TaskEndReason: " + e)
- None
+ // we might rack up a bunch of fetch-failures in rapid succession, due
to a bad node. But
--- End diff --
I might keep this comment in the FetchFailed task reason (easier to get out
of date here), especially since the countTowardsTaskFailures variable is so
clearly named
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
