Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14773#discussion_r77295324
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala ---
@@ -90,17 +90,31 @@ case class RefreshResource(path: String)
/**
* Builds a map in which keys are case insensitive
*/
-class CaseInsensitiveMap(map: Map[String, String]) extends Map[String,
String]
+class CaseInsensitiveMap[T] private(baseMap: Map[String, T]) extends
Map[String, T]
--- End diff --
If we decide to go case-insensitive all usage of options, probably we don't
need class CaseInsensitiveMap adapter class any longer. Instead, we should
probably convert to user provided options to lower case directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
