Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r77308494
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -61,8 +63,12 @@ private[columnar] trait CompressibleColumnBuilder[T <:
AtomicType]
super.initialize(initialSize, columnName, useCompression)
}
+ // The various compression schemes, while saving memory use, cause all
of the data within
+ // the row to become unaligned, thus causing crashes. Until a way of
fixing the compression
+ // is found to also allow aligned accesses this must be disabled for
SPARC.
+
protected def isWorthCompressing(encoder: Encoder[T]) = {
- encoder.compressionRatio < 0.8
+ encoder.compressionRatio < 0.8 &&
!misalignedArch.contains(System.getProperty("os.arch"))
--- End diff --
No, just write `val misalignedArch = Set("sparc",
"sparcv9").contains(System.getProperty("os_arch")` above, then refer to this
boolean flag. Doesn't have to be more complex than that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
